Make error context a non-enumerable property to avoid serialization errors #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may also address what #46 is trying to address: that is making the error context not writable. |
|
@othiym23 any comments on this one? We've found this really helpful preventing crashes in our service which frequently serializes error objects (for responses, logging, etc). Thanks! |
|
@msmithgu there is one more place where the That should have the same behavior... |
|
Thanks! I'll add some tests for this and get it merged. 😸 |
|
this fixed my problem! 3q |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error contexts can contain complex objects with circular references. By making the error context property non-enumerable, it's still accessible directly but won't be included automatically if someone tries to serialize the exception for logging.